Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing packages from other branches #6

Closed
bebbs opened this issue Oct 22, 2020 · 1 comment
Closed

Support publishing packages from other branches #6

bebbs opened this issue Oct 22, 2020 · 1 comment

Comments

@bebbs
Copy link

bebbs commented Oct 22, 2020

I maintain a package where the default branch name is main instead of master, I think it may also be the jackfan.us.kg-wide default for new repositories now (?)

Would love to use elm-publish-action to automate publishing new versions, but to do that I think this action would have to support publishing packages from main as well as master? It looks like it checks for refs/heads/master only here:

if (githubRef !== 'refs/heads/master') {

Would a patch to allow publishing from main / master, or a more generic solution to make it configurable be welcomed?

@dillonkearns
Copy link
Owner

Hello @bebbs! Ah yes, great point. It would be great to use the repo's default branch. There's already a feature to help with this: https://github.blog/changelog/2020-07-22-github-actions-better-support-for-alternative-default-branch-names/. So we should be able to just use $default-branch now instead of hardcoding the branch to master.

Happy to discuss more if you have any other thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants