Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfcminbuilder #3

Open
mpadge opened this issue Apr 19, 2018 · 1 comment
Open

sfcminbuilder #3

mpadge opened this issue Apr 19, 2018 · 1 comment

Comments

@mpadge
Copy link
Contributor

mpadge commented Apr 19, 2018

Pretty easy to extend this to sfc objects by pilfering the make_sfc function here. That would then be a the foundation of a pretty useful package in its own right, offering a very lightweight way to convert rectangular stuff into sfc objects. Happy to merge this code with your approval?

@mdsumner
Copy link
Contributor

I am happy to do this, I've only done this partially in different places. :) My recent insight was to 1) keep sfg in a raw list, 2) template the overall classing of the sfc, and what you're doing here looks right!

(sf itself is admirably general with mixed types, but at the expense of most common constructors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants