Review Windows-specific code

[soc]

I'm not a Windows developer, so I'm not experienced in dealing with the various native Windows APIs.

It would be really helpful if someone more knowledgeable than me could have a look at https://github.com/soc/directories-rs/blob/master/src/win.rs#L82 and make sure that I have used the Windows API correctly, and haven't introduced any glaring issues on the Rust side either.

[francesca64]

Feel free to ping me in the future for any native API review (at least for Windows, X11, and macOS). I maintain winit, so I have to interact with them on a regular basis.

[soc]

@francesca64 Amazing, thanks a lot!

Could you have a look whether https://github.com/soc/directories-rs/blob/master/src/win.rs#L84 correctly manages the memory coming from the Windows API?

[francesca64]

Looks good to me. OsString copies the data, and you free the original with CoTaskMemFree just as the docs for SHGetKnownFolderPath say.

[soc]

@francesca64 Thank you. I looked at code like https://github.com/tbu-/dirs/blob/master/src/windows/sys.rs#L88 that explicitly defined Dropand was concerned that there was a way to leave the method in my code without cleanup that I didn't see..

[soc]

@francesca64 Last question: Do the changes in c0d6956 look good to you?

[francesca64]

Yeah, that looks good.

[soc]

@francesca64 Thanks for your help! I'll close this ticket then.