Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] how many PR left? #58

Closed
3 tasks
jodth07 opened this issue Oct 25, 2018 · 5 comments
Closed
3 tasks

[Feature Request] how many PR left? #58

jodth07 opened this issue Oct 25, 2018 · 5 comments
Labels
status: approved The issue has received a core developer's approval

Comments

@jodth07
Copy link
Contributor

jodth07 commented Oct 25, 2018

Is it still possible for you to get a t-shirt for completing 5 PRs now?

In order to find that out, we want to know how maybe has been completed, and how many are left. Therefore, we have proposed the create of this Feature Request, which will tell us these info whenever we want to know, as we are pushing towards the finish line.

screen shot 2018-10-25 at 1 30 42 pm

Implementation details

List the changes required for the implementation here.

  • Write the bot command prsleft
  • access hacktoberfest API to get current number of completed PRs
  • provide remaining numbers of PRs completed with numbers left

Additional information

Link to stats:
https://hacktoberfest.digitalocean.com/stats
You can check the PR #6 and #7 on access and use of the API

@JoshuaRM
Copy link

I would like to work on this!

JoshuaRM pushed a commit to JoshuaRM/hacktoberbot that referenced this issue Oct 30, 2018
This was referenced Oct 30, 2018
@ByteCommander ByteCommander added status: approved The issue has received a core developer's approval status: WIP Work In Progress labels Oct 31, 2018
@sco1 sco1 added intermediate and removed status: WIP Work In Progress intermediate labels Nov 19, 2018
@jerbob
Copy link
Contributor

jerbob commented Feb 3, 2019

Closing until next October.

@scragly
Copy link
Contributor

scragly commented Mar 25, 2019

Hackstats already show how many PRs are left for a set github username or a members linked account. This essentially covers the scope of this feature, so this can be closed.

@scragly scragly closed this as completed Mar 25, 2019
@scragly
Copy link
Contributor

scragly commented Mar 25, 2019

I mistook the feature to be for personal PRs until the member get's a shirt, not an indicator for when all shirts have been given out and the cutoff has been reached for any future PRs being able to claim it. Reopened.

@scragly scragly added this to the Halloween 2019 milestone Sep 20, 2019
@sco1
Copy link
Contributor

sco1 commented Oct 2, 2019

A very good point was raised that this feature kinda detracts from the core mission of the event: getting folks interested in and experienced with contributing to open source. Getting a shirt is just an added bonus and we don't want to discourage folks from contributing just because they're not going to get one.

@sco1 sco1 closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved The issue has received a core developer's approval
Projects
None yet
Development

No branches or pull requests

7 participants