Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Audit Sorting Is Not Idempotent #225

Open
goakley opened this issue Jan 14, 2025 · 0 comments
Open

Group Audit Sorting Is Not Idempotent #225

goakley opened this issue Jan 14, 2025 · 0 comments

Comments

@goakley
Copy link
Contributor

goakley commented Jan 14, 2025

When the React component powering /groups/<group>/audit updates (calls the API), the order of items in the table will sometimes change. This happens when sorting by "Started", but may happen with other types of sorts as well.

Here is the same page, after waiting 5 seconds between each screenshot. Note that the first two columns have swapped (it's more obvious when the redacted information is shown, but you can see the "member or owner" values are opposite after the update).

Image
Image

I looked at the responses from api/audit/users?group_id=<group>&page=0&per_page=20&order_by=created_at&order_desc=true, and it looks like the API itself returns a different order for each call (even though the URL parameters are the same and no additional audit entries have been created). So this may be a bug in how data is fetched from the database. I am not sure if it happens for other audit pages.

This is annoying when trying to review audit information to spot when someone lost access, as multiple rows are usually affected and swap at the most inconvenient of times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant