Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOICE_CONNECTION_TIMEOUT never cleared if authentication successful #2752

Closed
1 of 2 tasks
Tenrys opened this issue Aug 15, 2018 · 0 comments
Closed
1 of 2 tasks

VOICE_CONNECTION_TIMEOUT never cleared if authentication successful #2752

Tenrys opened this issue Aug 15, 2018 · 0 comments

Comments

@Tenrys
Copy link

Tenrys commented Aug 15, 2018

Please describe the problem you are having in as much detail as possible:

Few days ago I noticed my bot was unable to connect to a few voice servers, which resulted in me getting some VOICE_CONNECTION_TIMEOUT exceptions, which I wasn't able to handle properly:

Trying to catch the promise returned by join only caught uWs having issues, but not these ones. I also attempted adding listeners to the connection's error and failed events, to no avail. I ended up using the uncaughtException process event to avoid the bot crashing entirely in the mean time. No audio would play, and I had no idea what to do, so I concluded this wasn't something on my part and decided to wait and ask around the Discord.js server, nobody had any idea.

Okay. Now with Discord having caught on to some apparent connectivity issues, I gave voice on my bot another try, on the server regions that had issues. It works again, but now VOICE_CONNECTION_TIMEOUT exceptions are getting throwns and caught from the join returned promise / handled the events, even though it works? What?

I took a quick look at the current code on master and it seems that besides when the bot fails to authenticate or disconnects, that timeout is never cleared, at least not in VoiceConnection.js. Is this intended, is there something I'm not getting or doing right?

Further details:

  • discord.js version: master branch, commit 700201e
  • Node.js version: v8.11.3
  • Operating system: Ubuntu 14.04.5 LTS
  • Priority this issue should have – please be realistic and elaborate if possible: High
  • I found this issue while running code on a user account
  • I have also tested the issue on latest master, commit hash: 700201e
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants