Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APIRequest): only use form data when actually sending files #3917

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Mar 8, 2020

Please describe the changes this PR makes and why it should be merged:

This PR patches APIRequest to only make use of FormData when actually sending files.
This initially "broke" by APIMessage (consistently) returning an array for files even if no files are being sent.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants