Conan Deps #1785
Merged
Conan Deps #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
tidy-cmake-conan-deps
branch
6 times, most recently
from
28a1814 to
10997fd
Compare
trisyoungs
force-pushed
the
tidy-cmake-conan-deps
branch
from
92d3c48 to
e73f7fb
Compare
|
Apologies @rhinoella and @rprospero that this is a bit of a beast, but most changes beyond the workflow yml and the root CMakeLists.txt is reduction, which is nice! |
rhinoella
approved these changes
Feb 12, 2024
rprospero
approved these changes
Feb 12, 2024
Co-authored-by: Noella Spitz <[email protected]>
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Noella Spitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
quickmassive, week-long struggle of a PR to prevent unnecessary dependencies on conan-provided libs for platforms that don't need them. This ballooned out of its original scope quite quickly, but ultimately clarifies and improves our cross-platform build system, IMHO.Our GitHub workflows and the root
CMakeLists.txtget the most attention, the the latter now callingconanautomatically rather than leaving this to the user.Closes #800.