Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation data manager as QML TableView #1809

Merged
merged 19 commits into from
Mar 7, 2024
Merged

Simulation data manager as QML TableView #1809

merged 19 commits into from
Mar 7, 2024

Conversation

RobBuchananCompPhys
Copy link
Contributor

@RobBuchananCompPhys RobBuchananCompPhys commented Feb 26, 2024 •
edited
Loading

Things to keep in mind:

  • the QML table is not yet hooked up to the sorting/filtering functionality provided by the simulation proxy model. I think it should be relatively straightforward - essentially set the simProxy as the model context property, and probably some changes on the QML side, so a bit more work probably needed
  • Obviously, a search box is needed for the user to be able to filter by text
  • Updating unit tests

@RobBuchananCompPhys RobBuchananCompPhys marked this pull request as ready for review March 5, 2024 12:47
rprospero
rprospero approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@rprospero rprospero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions, but generally approved (pending our discussion from Team about wrapping QSortProxyFilter)

src/gui/qml/simulationDataManager/SimulationDataManager.qml Outdated Show resolved Hide resolved
src/gui/qml/simulationDataManager/SimulationDataManager.qml Outdated Show resolved Hide resolved
@rprospero rprospero merged commit a8a8155 into develop Mar 7, 2024
10 checks passed
@rprospero rprospero deleted the simulation_data_manager_qml_translation branch March 7, 2024 16:52
rprospero pushed a commit that referenced this pull request Mar 11, 2024
@RobBuchananCompPhys @rprospero
refactor: Simulation data manager as QML TableView (#1809)
2c55765 
Co-authored-by: Adam Washington <[email protected]>

Rewrite the Data Manager dialog to use QML.
rhinoella pushed a commit that referenced this pull request Apr 2, 2024
@RobBuchananCompPhys @rhinoella
refactor: Simulation data manager as QML TableView (#1809)
d121529 
Co-authored-by: Adam Washington <[email protected]>

Rewrite the Data Manager dialog to use QML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisyoungs trisyoungs Awaiting requested review from trisyoungs

@rprospero rprospero Awaiting requested review from rprospero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobBuchananCompPhys @rprospero