Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Correctly Set Working Directory in GUI #1829

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Fix: Correctly Set Working Directory in GUI #1829

merged 14 commits into from
Apr 2, 2024

Conversation

rhinoella
Copy link
Contributor

@rhinoella rhinoella commented Apr 2, 2024 •
edited
Loading

Currently dissolve does not set the working directory to the input file directory when you start from new, causing the exports to spew out in the GUI binary directory.

This PR fixes that, implementing a new function setInputFilename in the GUI class.

@rhinoella rhinoella requested a review from trisyoungs April 2, 2024 09:15
trisyoungs
trisyoungs approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/gui/gui.h Outdated Show resolved Hide resolved
src/gui/menu_file.cpp Outdated Show resolved Hide resolved
rprospero and others added 10 commits April 2, 2024 15:04
@rprospero @trisyoungs @rhinoella
1806 faster combinations (#1807)
5c18e70 
Co-authored-by: Tristan Youngs <[email protected]>
@trisyoungs @rprospero
@jws-1 @rhinoella
1576 More CIF Unit Tests (#1804)
fceb24a 
Co-authored-by: Adam Washington <[email protected]>
Co-authored-by: Jared Swift <[email protected]>
@rhinoella
Update Compillation Docs for new test method (#1810)
c369152
@rhinoella @trisyoungs
@rprospero @Danbr4d @jws-1
1620 Compare Module GUI Implementation (#1662)
1b60ce2 
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Adam Washington <[email protected]>
Co-authored-by: Danbr4d <[email protected]>
Co-authored-by: Jared Swift <[email protected]>
@github-actions @trisyoungs @rhinoella
Update website release info (v1.4.3) (#1811)
6e74117 
Co-authored-by: trisyoungs <[email protected]>
@RobBuchananCompPhys @rhinoella
refactor: Simulation data manager as QML TableView (#1809)
d121529 
Co-authored-by: Adam Washington <[email protected]>

Rewrite the Data Manager dialog to use QML.
@rprospero @rhinoella
feat: wrap QSortFilterProxy so it is accessible from QML (#1813)
59d7a56 
This enables immediate search in the Data Manager Dialog (and other tables as QML support expands).  This also officially adds support for regular expression search in these tables.
@jws-1 @trisyoungs @rhinoella
Analysis Refactoring - Part 2 (#1795)
6692aab 
Co-authored-by: Tristan Youngs <[email protected]>
@Danbr4d @rhinoella
Modifier Oxygen Sites Module setup (#1793)
fd086ef
@rprospero @rhinoella
fix: include final line of multi-line error messages (#1822) (#1823)
dbdcb95
@rhinoella rhinoella changed the base branch from develop to release/0.9.0 April 2, 2024 14:06
@rhinoella rhinoella changed the base branch from release/0.9.0 to develop April 2, 2024 14:06
@rhinoella rhinoella added Type: Bug General bug / issue Scope: GUI Related to the GUI labels Apr 2, 2024
@rhinoella rhinoella merged commit 5e9cc8e into develop Apr 2, 2024
10 checks passed
@rhinoella rhinoella deleted the fix-exports branch April 2, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisyoungs trisyoungs trisyoungs approved these changes

Assignees
No one assigned
Labels
Scope: GUI Related to the GUI Type: Bug General bug / issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhinoella @trisyoungs @rprospero @RobBuchananCompPhys @jws-1 @Danbr4d