-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update docs #1841
doc: Update docs #1841
Conversation
…ons with 'tab_' anymore)
…odes and modules in css
… include new steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here. Not a fund job, I'm sure! Couple of questions / corrections to make.
@@ -1,2 +1,4 @@ | |||
{{ $type := index .Params 0 }} | |||
<a href="{{ ref .Page $type }}"><span class="module-link module-link-{{ lower $type }}">{{ $type }}</span></a> | |||
<a href="{{ ref .Page $type }}" class="icon-text-container module-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a reason why I had to one-line these shortcodes - I don't think they worked correctly for me unless I did so. However, that was a while ago, so perhaps things have changed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately they still need to be one line in some cases, but I've modified the CSS a bit for this one (not using pseudo-elements) so it doesn't have to be one line. It allows us to avoid having to update a list of modules in the CSS.
Co-authored-by: Tristan Youngs <[email protected]>
@trisyoungs Regarding updating the temperature steps, I will do that in PR #1855 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.