Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update docs #1841

Merged
merged 35 commits into from
Apr 15, 2024
Merged

doc: Update docs #1841

merged 35 commits into from
Apr 15, 2024

Conversation

rhinoella
Copy link
Contributor

No description provided.

@rhinoella rhinoella changed the title Update docs Docs: Update docs Apr 10, 2024
@rhinoella rhinoella changed the title Docs: Update docs docs: Update docs Apr 11, 2024
@rhinoella rhinoella changed the title docs: Update docs doc: Update docs Apr 12, 2024
@rhinoella rhinoella requested a review from trisyoungs April 12, 2024 21:18
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work here. Not a fund job, I'm sure! Couple of questions / corrections to make.

web/docs/examples/argon/step1.md Outdated Show resolved Hide resolved
web/docs/examples/argon/step2.md Outdated Show resolved Hide resolved
web/docs/examples/argon/step2.md Outdated Show resolved Hide resolved
web/docs/examples/argon/step4a.md Outdated Show resolved Hide resolved
web/docs/examples/argon/step4a.md Outdated Show resolved Hide resolved
web/docs/examples/benzene/step5.md Outdated Show resolved Hide resolved
web/docs/examples/silica/step1.md Outdated Show resolved Hide resolved
web/docs/userguide/get/compilation.md Outdated Show resolved Hide resolved
@@ -1,2 +1,4 @@
{{ $type := index .Params 0 }}
<a href="{{ ref .Page $type }}"><span class="module-link module-link-{{ lower $type }}">{{ $type }}</span></a>
<a href="{{ ref .Page $type }}" class="icon-text-container module-link">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a reason why I had to one-line these shortcodes - I don't think they worked correctly for me unless I did so. However, that was a while ago, so perhaps things have changed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately they still need to be one line in some cases, but I've modified the CSS a bit for this one (not using pseudo-elements) so it doesn't have to be one line. It allows us to avoid having to update a list of modules in the CSS.

@rhinoella rhinoella requested a review from trisyoungs April 15, 2024 10:36
@rhinoella
Copy link
Contributor Author

@trisyoungs Regarding updating the temperature steps, I will do that in PR #1855

Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhinoella rhinoella merged commit db3f594 into develop Apr 15, 2024
1 check passed
@rhinoella rhinoella deleted the docs-update branch April 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants