build: Probe qml #1869
Merged
build: Probe qml #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhinoella
reviewed
Apr 18, 2024
| @@ -62,16 +62,17 @@ runs: | |||
| appName=Dissolve-GUI-${{ runner.arch }} | |||
| appDirName=${appName}.app | |||
| packageName=Dissolve-GUI-${{ runner.arch }}-${{ env.dissolveVersion }} | |||
| dmgName=Dissolve-GUI-${{ env.dissolveVersion }}-${{ runner.arch }} | |||
There was a problem hiding this comment.
What is the purpose of dmgName with the arch and version flipped?
There was a problem hiding this comment.
Soooooo...... Other packages we generate for other platforms all follow the format Dissolve-GUI-X.Y.Z[-arch].abc but the OSX ones didn't. The Hugo shortcode assumes the first format and so was generating links to the dmg files that were not correct. Rather than being specific for OSX on the Hugo end, I decided a quick mod to the CI was a better approach. No doubt the scripts and other stuff (e.g. pre-dmg) could be modified too, but that was a bigger job and I was just seeking a quick solution for the workshop.
rhinoella
reviewed
Apr 18, 2024
trisyoungs
force-pushed
the
maybe-mac-qml-fix
branch
from
8a1b017 to
1c58835
Compare
trisyoungs
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.