build: Fix Qt library install for Windows #1870
Conversation
Because that would just be a *stupid* default behaviour 🙄
|
I can confirm that this correctly loaded the dialogs under Windows on my laptop. The one concerning oddity is that it did not work when launched from the installer, but running it subsequently from the Start Menu was effective. My three hypotheses are:
|
There was a problem hiding this comment.
So I cannot try the installer because, you know, Sophos, but on my local Windows machine the zip file is missing the qml, platforms, iconengines, and imageformats directories. Looking at the CI the relevant files are there when the installer gets unpacked, but the subsequent directory move and zip misses the subdirs...
|
@trisyoungs It now requires the full installer to get things in place, so you'll want to use the installer package and not just the archive. |
There was a problem hiding this comment.
@rprospero Just to clarify, the zipped contents derived from the Inno installer should work just the same, but not require installation (and its the only way I can deploy on my own, and other PCs around ISIS! The problem is that the new install methodology puts the deployed libs in a slightly different structure than before. Previously the zip file assumed that the important bits were all in app/bin but this is no longer the case. On lines 69/70 you can see:
mv ${exeBase}/app/bin/* $exeBase
mv ${exeBase}/app ./
I think this can just be replaced with:
mv ${exeBase}/app/* $exeBase
rm -r ${exeBase}/app
That should yield a "full" zip.
There was a problem hiding this comment.
@trisyoungs Good call on the suggestions. It now runs straight from the zip archive on my machine. Also cleared up whatever I had going on with the first run through the installer.
rprospero
changed the title
This uses some Qt magic in cmake to create the deployment script for us.