build: Fix single-page example generation #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
changed the title
rprospero
approved these changes
Jul 29, 2024
| pandoc --pdf-engine=xelatex -V 'mainfont:DejaVuSerif.ttf' -V 'sansfont:DejaVuSans.ttf' -V 'monofont:DejaVuSansMono.ttf' index.html -o ../${example}.pdf | ||
|
|
||
| # "Fix" image links | ||
| sed "s:/img:../../../static/img:g" index.html > index_pdf.html |
There was a problem hiding this comment.
My mind went on quite a trip trying to parse this sed statement before it finally clicked that you were using the colon as the delimited and not the traditional slashes. Which was exactly the right call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting off as another attempt to get us PDFs of our examples (
pandocnow just crashes, and an alternative in the form ofmd-to-pdfvia npm doesn't work either) this PR just fixes the generation of single-page examples. Users can print those to PDF themselves if required.