build: Add QuickPlot into QML GUI #1963
Conversation
rprospero
changed the title
I really don't get where the runtime renderer is
This update prevents us from building the QuickPlot tests and demo executable.
| git submodule update --init --recursive | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "GitHub Actions" | ||
| git rm .gitmodules | ||
|
|
||
| cp -r QuickPlot QuickPlot.bak | ||
| rm -rf QuickPlot.bak/.git | ||
| git rm -r QuickPlot | ||
| git commit -m "Kill submodule" | ||
|
|
||
| mv QuickPlot.bak QuickPlot | ||
| git add QuickPlot | ||
| git commit -m "Resurrect submodule" | ||
|
|
||
| nix --version |
There was a problem hiding this comment.
Is this testing, or a workaround? If the latter, may we a comment as to why it is necessary?
There was a problem hiding this comment.
This is a work around for something that appears to be a very specific nix bug. I've added comments to the file explaining the nature of the problem.
| @@ -44,11 +44,11 @@ runs: | |||
| path: ${{ runner.temp }}/qt | |||
|
|
|||
| - name: Install Qt | |||
| if: ${{ steps.cache-qt.outputs.cache-hit != 'true' }} | |||
| # if: ${{ steps.cache-qt.outputs.cache-hit != 'true' }} | |||
There was a problem hiding this comment.
Fantastic. If we no longer need Qt caches for Windows and OSX then we can ditch the "Retrieve Qt Cache" step prior to this one, although I understand if you want to leave this for a follow-up PR.
There was a problem hiding this comment.
Sadly, this was just a testing issue that leaked through. I had to temporarily disable the cache because I was changing the Qt install and it kept loading the cached version. It will build without the cache, but we might get into issues with too many downloads, so it's better to keep it cached.
PR is a minimal proof of concept adding the plotting library from QuickPlot into the Dissolve QML GUI. Using the Qt Plugin system, we can import both the QML and C++ components of the library.
We load QuickPlot through a git submodule, which I suspect will break a load of the CI. There's also several changes that need to be made before this could be considered for merge. However, I wanted to put the code out in front of everyone to ensure that people are happy with how this works.
Necessary Changes
qt_add_qml_modulefor dissolve gui qml