Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coulombic as additional potential #1981

Merged
merged 5 commits into from
Oct 10, 2024
Merged

feat: coulombic as additional potential #1981

merged 5 commits into from
Oct 10, 2024

Conversation

Danbr4d
Copy link
Contributor

@Danbr4d Danbr4d commented Oct 1, 2024

Added in the ability to add coulombic potentials as an additional potential so that we can manually describe the interactions.

@Danbr4d Danbr4d requested a review from trisyoungs October 1, 2024 10:21
@Danbr4d Danbr4d self-assigned this Oct 1, 2024
src/math/function1D.cpp Outdated Show resolved Hide resolved
src/math/function1D.cpp Outdated Show resolved Hide resolved
src/math/function1D.cpp Outdated Show resolved Hide resolved
src/math/function1D.cpp Outdated Show resolved Hide resolved
@Danbr4d Danbr4d requested a review from trisyoungs October 1, 2024 12:39
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small corrections / comments to deal with, then good to go.

src/math/function1D.cpp Outdated Show resolved Hide resolved
src/math/function1D.cpp Outdated Show resolved Hide resolved
src/math/function1D.cpp Outdated Show resolved Hide resolved
@Danbr4d Danbr4d merged commit 9694b41 into develop Oct 10, 2024
10 checks passed
@Danbr4d Danbr4d deleted the coulomb-potential branch October 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants