build: Fix passing of nixHash to QC, run benchmarks as part of main build #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
new-version-management-4
branch
from
24f1285 to
9b3f722
Compare
rprospero
approved these changes
Jan 22, 2025
Co-authored-by: Adam Washington <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few final adjustments to the new CI, in particular removing the separate
benchmarks.ymlworkflow and running this as an optional addendum to the main Linux CLI build.Still failing on the QC check, but looking good otherwise. Except, @rprospero, as I have just noticed - the benchmarks is taking an age and basically cripples the Linux CLI build. It may be stuck, or has hung, or there is another issue at play...