-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository name regex is outdated [docs]. #17
Comments
i would like too fix this issue |
@rahul3002 do you want to open a PR that fixes this? |
yes i want to open |
Please, be our guest -- we welcome contributions :) |
Before we change; please double check if the regex in code matches the actual specification; in case there's a bug in the code; https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-manifests |
sure will check it, I'm working on it |
I'm unable to understand what kind of regex u want to update In it |
Please update the regex mentioned in docs because it is outdated.
https://docs.docker.com/registry/spec/api/#overview
Now multiple dashes and double underscore is allowed.
https://github.com/docker/distribution/blob/master/reference/regexp.go#L18
I used the go playground which gave me as an output this regex
[a-z0-9]+(?:(?:(?:[._]|__|[-]*)[a-z0-9]+)+)?
https://play.golang.org/p/wQ4w431jvS
The text was updated successfully, but these errors were encountered: