After implementation of digga's rakeLeaves, can't rebuild in the presence of */modules-list.nix

[cipharius]

Solution: before updating to the implementation of rakeLeaves for modules, make sure to first merge 5bd943f — which tries to tell you what to do when the relevant merge conflict appears.

Expected Behavior

Rebuild without errors after flake update.

Current Behavior

I get an undescriptive error originating from nixpkgs repository. It might be related to my setup, but the error doesn't really help finding the reason it's broken. Tested both core and develop branches, both don't work.

Also, core branch has incorrect url to digga main branch, as it refers to non-existing master branch.

The error in question:

error: value is a list while a set was expected

       at /nix/store/m35mc9chdjl73yk17vcn4bsidngxqzky-source/lib/modules.nix:285:44:

          284|         options = {};
          285|         config = addFreeformType (addMeta (removeAttrs m ["_file" "key" "disabledModules" "require" "imports" "freeformType"]));
             |                                            ^
          286|       };
(use '--show-trace' to show detailed location information)

the store path leads to nixpkgs deriviation.

Steps to Reproduce

1. nix develop
2. bud rebuild HOST switch

Your Environment

My devos repository: https://github.com/cipharius/devos

[blaggacao]

m here refers to a module, which for some reason appears to be a list. You'd have to look a little further up the trace stack to see where the offending value is actually coming from.

If you wish to publish the stactrace on e.g. 0x0.st I could try to help you analyze it.

Also, core branch has incorrect url to digga main branch, as it refers to non-existing master branch.

Thanks for the the note. I'll fix that asap.

[cipharius]

Here, I uploaded the whole stack trace: http://0x0.st/-WnO.txt

[blaggacao]

Ok that didn't reveal much. 😕 Did you try to run devos/core with latest digga/main? That is probably not going to work.

Maybe we should pin core to a specific known working digga commit until we are able to merge develop back into core...

[cipharius]

I was originally on core and switched to develop in hopes that the misterious issue would be resolved there.

I've tried changing nixpkgs source from release to master, but I get the same error.

[blaggacao]

Ah, so it looks like you didn't resolve a merge conflict in the sense of the new digga lib.importModules. this file would be interpreted as a module via lib.importModules's use of lib.rakeLeaves.

[blaggacao]

I hope this commit would have been able to hint appropriately and within context would it have been available before 5bd943f

[cipharius]

Good catch!

Yeah, file deletion was a subtle conflict during merge alongsides more obvious conflicts, this notice would have helped.
But in general, I think switch to more consistent rakeLeaves approach is an important change.

Removing the modules-list.nix file does fix the issue, thank you!