Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement apps as fallback or not at all #79

Closed
blaggacao opened this issue Jan 11, 2021 · 2 comments · Fixed by #88
Closed

implement apps as fallback or not at all #79

blaggacao opened this issue Jan 11, 2021 · 2 comments · Fixed by #88

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Jan 11, 2021

https://github.com/nrdxp/nixflk/blob/d0fe508da20695bd72c1a5eebd3cb113778366ac/flake.nix#L88-L104

nix run falls back to inspecting the self.packages attribute set.

app declarations are only needed when in packages.<system>.<pname> and /bin/<name> and are not euqal, for example:

packages.<system>.coreutils
but:
/bin/cat

It appears to me for the sake of simplicity, the app generation could be dropped. Those naming conflicts are extremely rare and the user could probably declare apps manually in such cases.

@blaggacao
Copy link
Contributor Author

blaggacao commented Jan 11, 2021

I think I'll avoid implementing apps in numtide/flake-utils#18 for the time being.

@blaggacao blaggacao changed the title implement apps as fallback implement apps as fallback or not at all Jan 11, 2021
@nrdxp
Copy link
Collaborator

nrdxp commented Jan 11, 2021

Since the filtering of apps requires building the package to test for bin dir, your probably right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants