fix(lib/ops): ensure the getName contract is uphold for operables #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #318
Context
Operables wrap packages, and then they are symlinked via
lib.getExe
intothe container.
Prior to this commit, using
package.name
(which is the wrong attribute, anyways),we where furnishing that name to
/bin/<name>
.While
lib.getBin
reads the store path verbatim and thereby honors that name,lib.getName
resolves differently via the following implementation resultingin naming mismatches for the call to
getExe
which ultimately linked/bin/entrypoint
in mkOCI to a non-existing exectuable:Solution
Feed to the consumer (
getExe
) it's very own contract (getName
)@Pegasust would you have the ability to test this fix in your particular situation?