Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container support #82

Closed
jgeusebroek opened this issue Jan 21, 2019 · 6 comments
Closed

Docker container support #82

jgeusebroek opened this issue Jan 21, 2019 · 6 comments

Comments

@jgeusebroek
Copy link
Contributor

Would you be interested in supporting Telegraf running in Docker? If so, I will be willing to add this feature. Before I start forking, I'd like to know if you are interested.

@dj-wasabi
Copy link
Owner

Hi @jgeusebroek

And what do you specifically mean with that? Its a bit unclear to me.

Kind regards,
Werner

@jgeusebroek
Copy link
Contributor Author

Hi Werner,

Your role handles the installation of Telegraf, and also the configuration.
Telegraf is also able to be run as a Docker container, but needs configuration. The latter is what this role already does.

I was thinking of adding another "platform", namely docker, and use the already existing configuration tasks. This shouldn't be too difficult to add.

Greets,

Jeroen

@jgeusebroek jgeusebroek changed the title Docker support Docker container support Jan 21, 2019
@dj-wasabi
Copy link
Owner

Hi @jgeusebroek

Yes, I'm familiar with running Telegraf in Docker. Can you bit explain what changes do you want to see that this role does for Telegraf running in Docker? And does it help you and hopefully other people - when changes are merged in this role - using this role to maintain Telegraf in your environment? If the answer is yes, please do create a PR. While making a PR, please think of "Molecule" (So we are able to test it and if there is no easy way to test it, then there is always the possibility that things can break with other commits) and of the documentation. 😄

Kind regards,
Werner

@jgeusebroek
Copy link
Contributor Author

Hi Werner,

Proof of concept: https://github.com/jgeusebroek/ansible-telegraf/tree/docker

Molecule testing should work fine, it will not interfere. Although It might be difficult to actually test the docker container itself. But since the container is managed by InfluxDB and the config is the same as the other platforms, I see no reason to test it. (famous last words).

Let me know what you think.


Jeroen

@dj-wasabi
Copy link
Owner

Hi Jeroen,

Thank you for making this possible. What I can see looks good to me, but please mention in the documentation that this only works for the telegraf docker image provided by InfluxDB, or you have to make it configurable so people can use their own image.

Kind regards,
Werner

@jgeusebroek
Copy link
Contributor Author

#85. Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants