-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container support #82
Comments
Hi @jgeusebroek And what do you specifically mean with that? Its a bit unclear to me. Kind regards, |
Hi Werner, Your role handles the installation of Telegraf, and also the configuration. I was thinking of adding another "platform", namely docker, and use the already existing configuration tasks. This shouldn't be too difficult to add. Greets, Jeroen |
Hi @jgeusebroek Yes, I'm familiar with running Telegraf in Docker. Can you bit explain what changes do you want to see that this role does for Telegraf running in Docker? And does it help you and hopefully other people - when changes are merged in this role - using this role to maintain Telegraf in your environment? If the answer is yes, please do create a PR. While making a PR, please think of "Molecule" (So we are able to test it and if there is no easy way to test it, then there is always the possibility that things can break with other commits) and of the documentation. 😄 Kind regards, |
Hi Werner, Proof of concept: https://github.com/jgeusebroek/ansible-telegraf/tree/docker Molecule testing should work fine, it will not interfere. Although It might be difficult to actually test the docker container itself. But since the container is managed by InfluxDB and the config is the same as the other platforms, I see no reason to test it. (famous last words). Let me know what you think. Jeroen |
Hi Jeroen, Thank you for making this possible. What I can see looks good to me, but please mention in the documentation that this only works for the telegraf docker image provided by InfluxDB, or you have to make it configurable so people can use their own image. Kind regards, |
#85. Done :) |
Would you be interested in supporting Telegraf running in Docker? If so, I will be willing to add this feature. Before I start forking, I'd like to know if you are interested.
The text was updated successfully, but these errors were encountered: