From a11694ff86caf84bfe511a42a8670e129864b9e8 Mon Sep 17 00:00:00 2001
From: Werner Dijkerman <werner@dj-wasabi.nl>
Date: Sun, 21 Apr 2019 18:17:54 +0200
Subject: [PATCH] Various small changes for molecule

---
 defaults/main.yml                       |   2 ++
 molecule/default/tests/test_default.py  |  22 +++++++++++-----------
 molecule/default/tests/test_default.pyc | Bin 1125 -> 0 bytes
 tasks/Debian.yml                        |   2 +-
 tasks/RedHat.yml                        |   5 +++--
 5 files changed, 17 insertions(+), 14 deletions(-)
 delete mode 100644 molecule/default/tests/test_default.pyc

diff --git a/defaults/main.yml b/defaults/main.yml
index ec6d83d..485503c 100644
--- a/defaults/main.yml
+++ b/defaults/main.yml
@@ -4,6 +4,8 @@
 telegraf_agent_version: 1.10.0
 telegraf_agent_version_patch: 1
 telegraf_agent_package: telegraf
+telegraf_agent_package_file_deb: telegraf_{{ telegraf_agent_version }}-{{ telegraf_agent_version_patch }}_{{ telegraf_agent_package_arch }}.deb
+telegraf_agent_package_file_rpm: telegraf-{{ telegraf_agent_version }}-{{ telegraf_agent_version_patch }}.{{ ansible_architecture }}.rpm
 telegraf_agent_package_path: /tmp
 telegraf_agent_package_method: repo
 telegraf_agent_package_state: present
diff --git a/molecule/default/tests/test_default.py b/molecule/default/tests/test_default.py
index 507d6c3..aeab598 100644
--- a/molecule/default/tests/test_default.py
+++ b/molecule/default/tests/test_default.py
@@ -6,15 +6,15 @@
     os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('telegraf')
 
 
-def test_telegraf_running_and_enabled(Service, SystemInfo):
-    telegraf = Service("telegraf")
-    if SystemInfo.distribution not in ['opensuse-leap']:
+def test_telegraf_running_and_enabled(host):
+    telegraf = host.service("telegraf")
+    if host.system_info.distribution not in ['opensuse-leap']:
         assert telegraf.is_enabled
         assert telegraf.is_running
 
 
-def test_telegraf_dot_conf(File):
-    telegraf = File("/etc/telegraf/telegraf.conf")
+def test_telegraf_dot_conf(host):
+    telegraf = host.file("/etc/telegraf/telegraf.conf")
     assert telegraf.user == "telegraf"
     assert telegraf.group == "telegraf"
     assert telegraf.mode == 0o640
@@ -26,16 +26,16 @@ def test_telegraf_dot_conf(File):
     assert telegraf.contains('[[inputs.net]]')
 
 
-def test_telegraf_dot_d_dir(File):
-    telegraf = File("/etc/telegraf/telegraf.d")
+def test_telegraf_dot_d_dir(host):
+    telegraf = host.file("/etc/telegraf/telegraf.d")
     assert telegraf.user == "root"
     assert telegraf.group == "root"
     assert telegraf.mode == 0o755
     assert telegraf.is_directory
 
 
-def test_telegraf_dot_d(File):
-    telegraf = File("/etc/telegraf/telegraf.d/percpu-usage.conf")
+def test_telegraf_dot_d(host):
+    telegraf = host.file("/etc/telegraf/telegraf.d/percpu-usage.conf")
     assert telegraf.user == "telegraf"
     assert telegraf.group == "telegraf"
     assert telegraf.mode == 0o640
@@ -43,6 +43,6 @@ def test_telegraf_dot_d(File):
     assert telegraf.contains('totalcpu = false')
 
 
-def test_telegraf_package(Package):
-    telegraf = Package('telegraf')
+def test_telegraf_package(host):
+    telegraf = host.package('telegraf')
     assert telegraf.is_installed
diff --git a/molecule/default/tests/test_default.pyc b/molecule/default/tests/test_default.pyc
deleted file mode 100644
index 4864f1799ffcb2c49f9b06a71a5c47cedeae6c94..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1125
zcmeHFO>fgc5FOj;rzkn0s+XQ4p=N22kdP3fYJ(^Wu9Oy}=3@C{9oF4=&F(lfw7CGk
zh`+{>1I%vXwv@lX+Mb<#emgTeZ-bv(n~y*JI8R|Y0-9gZXWo*@==DGXjBb1nMm}&K
ziU5ih6f3|1idD#b*!ku`u?ATH<c!uKYr%KgxnV<`c2+2y_)R0kZF1k84El%f2mR<c
z{Ll~2PKM{v>*GNmZTeWs)T7y7eup%h0hwz`<tm~Ca}Ta5p9f|a(1)*!Wnc@r@WDL2
z1GXCQ%@U+zopx-d&}@=r98>mD88q0UrB(`Exo(vU$#Ionekm;DA-M;}aE(HheXW&t
zwAv!}jAO0ps$)xcxDAW;FnNazIAea1$0{wRF>*GIHOrOExHjy|m?hI>zt@`;&&+-@
z={?t&Tt@i0r=QRmm+XvHqS{MpA+x<OQ}U=_6D4_COMdI5N?i!T5V>Y1<z=jeVpFa~
zE(k$xP?Wij+11ruYPX3LWkT~5m7dM#_c=|tsEjB4-``D=ze3oAQO5JQme{Rk*rxM4
z%r!l-E#4r=tdjw+?YF&0UdJj!!U9kScdg%4-K|kb(~V0b63HW7mnHSy2DqU(B^=G^
zb&tA5)Pu$D;bQX|A-tRltx6YY%rRPAh^AE6uLU-=mEEfOUs5ZnmF~qvWpoc;+UxGL
LeBjgL?F4@S>^(?}

diff --git a/tasks/Debian.yml b/tasks/Debian.yml
index 096a8e8..7b26d01 100644
--- a/tasks/Debian.yml
+++ b/tasks/Debian.yml
@@ -65,7 +65,7 @@
 
 - name: "Debian | Download Telegraf package (online)"
   get_url:
-    url: https://dl.influxdata.com/telegraf/releases/telegraf_{{ telegraf_agent_version }}-{{ telegraf_agent_version_patch }}_{{ telegraf_agent_package_arch }}.deb
+    url: https://dl.influxdata.com/telegraf/releases/{{ telegraf_agent_package_file_deb }}
     dest: "{{ telegraf_agent_package }}"
   when:
     - telegraf_agent_package_method == "online"
diff --git a/tasks/RedHat.yml b/tasks/RedHat.yml
index 137e35b..498bfc2 100644
--- a/tasks/RedHat.yml
+++ b/tasks/RedHat.yml
@@ -10,7 +10,8 @@
 - name: Use RHEL 7 packages for Fedora
   set_fact:
     telegraf_redhat_releasever: 7
-  when: ansible_distribution == "Fedora"
+  when:
+    - ansible_distribution == "Fedora"
 
 - name: "RedHat | Add yum repository"
   yum_repository:
@@ -24,7 +25,7 @@
 
 - name: "RedHat | Download Telegraf package (online)"
   get_url:
-    url: https://dl.influxdata.com/telegraf/releases/telegraf-{{ telegraf_agent_version }}-{{ telegraf_agent_version_patch }}.{{ ansible_architecture }}.rpm
+    url: https://dl.influxdata.com/telegraf/releases/{{ telegraf_agent_package_file_rpm }}
     dest: "{{ telegraf_agent_package }}"
   when:
     - telegraf_agent_package_method == "online"