From 9cc966295c4e7ef5df834a4e6fed6e08bbeb0a79 Mon Sep 17 00:00:00 2001 From: matiboy Date: Sat, 24 Jan 2015 04:53:03 +0800 Subject: [PATCH 1/2] (fix) APNs: Missing _sent_notifications Define self._sent_notifications Fixes #104 --- apns.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apns.py b/apns.py index 826135f..fdc02db 100644 --- a/apns.py +++ b/apns.py @@ -480,7 +480,7 @@ def __init__(self, use_sandbox=False, **kwargs): self._error_response_handler_worker = None self._response_listener = None - self._sent_notifications = collections.deque(maxlen=SENT_BUFFER_QTY) + self._sent_notifications = collections.deque(maxlen=SENT_BUFFER_QTY) def _init_error_response_handler_worker(self): self._send_lock = threading.RLock() From 5f33de77850acc4ba70056b25f647c0cea6cbec3 Mon Sep 17 00:00:00 2001 From: matiboy Date: Mon, 26 Jan 2015 09:39:17 +0800 Subject: [PATCH 2/2] Check whether enhanced when sending multiple --- apns.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apns.py b/apns.py index fdc02db..b9b8314 100644 --- a/apns.py +++ b/apns.py @@ -480,7 +480,7 @@ def __init__(self, use_sandbox=False, **kwargs): self._error_response_handler_worker = None self._response_listener = None - self._sent_notifications = collections.deque(maxlen=SENT_BUFFER_QTY) + self._sent_notifications = collections.deque(maxlen=SENT_BUFFER_QTY) def _init_error_response_handler_worker(self): self._send_lock = threading.RLock() @@ -556,7 +556,8 @@ def _make_sure_error_response_handler_worker_alive(self): _logger.warning("error response handler worker is not started after %s secs" % TIMEOUT_SEC) def send_notification_multiple(self, frame): - self._sent_notifications += frame.get_notifications(self) + if self.enhanced: + self._sent_notifications += frame.get_notifications(self) return self.write(frame.get_frame()) def register_response_listener(self, response_listener):