Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup pre-commit for repo #1485

Closed
tim-schilling opened this issue Jul 20, 2021 · 2 comments · Fixed by #1495
Closed

Setup pre-commit for repo #1485

tim-schilling opened this issue Jul 20, 2021 · 2 comments · Fixed by #1495

Comments

@tim-schilling
Copy link
Member

To help lower barriers to contributing we should integrate pre-commit to the project. The main use for us would be to run the linter before a commit occurs to help prevent failed tests when PRs are opened. While this does change the setup time, it does conform to a larger python practice. That conformity should theoretically be more accessible when compared to knowing to run make styles before committing.

@matthiask
Copy link
Member

I don't use pre-commit much (we use custom hooks) but this definitely sounds like an excellent idea. django-debug-toolbar's make commands always give me a headache.

@tim-schilling
Copy link
Member Author

Yeah, perhaps larger python practice isn't the right phrase. Growing is more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants