Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: jekyll baseurl not set #278

Open
NikLeberg opened this issue May 18, 2024 · 0 comments
Open

docs: jekyll baseurl not set #278

NikLeberg opened this issue May 18, 2024 · 0 comments

Comments

@NikLeberg
Copy link

Hey there @djyde

Thanks for this, it works flawlessly. Small heads-up: In the docs for the jekyll integration there is a small error:

data-page-url="{{ site.url }}{{ page.baseurl }}{{ page.url }}"

It should be:

data-page-url="{{ site.url }}{{ site.baseurl }}{{ page.url }}" 

i.e. site.baseurl and not page.baseurl. Otherwise the baseurl as commonly used in GitHub Pages is not correctly found and I think comments could appear on multiple pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant