Skip to content
This repository has been archived by the owner on May 11, 2019. It is now read-only.

bunch prune is too aggressive #13

Closed
tamird opened this issue May 18, 2015 · 2 comments
Closed

bunch prune is too aggressive #13

tamird opened this issue May 18, 2015 · 2 comments
Labels

Comments

@tamird
Copy link
Contributor

tamird commented May 18, 2015

bunch prune seems not to handle sub-packages.

For instance, my project depends on github.com/cockroachdb/cockroach/util, but bunch prune only sees the top-level github.com/cockroachdb/cockroach, which is not used directly. bunch prune then removes github.com/cockroachdb/cockroach, which means I don't have github.com/cockroachdb/cockroach/util anymore, and that's Bad.

@dkulchenko
Copy link
Owner

Completely retooled the way bunch prune works in 404d8a4, this is now fixed.

@tamird
Copy link
Contributor Author

tamird commented May 19, 2015

Looks good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants