You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# If the request already has a `url` parameter, then it will already be appended to the callback URL.
ifrequest.params && request.params['url']
{}
else
{url: request.referer}
end
end
This only works for GET requests; for POST requests the parameter exists, but was never in in request.query_string to be copied by OmniAuth into the callback URL (see #callback_url and #query_string in OmniAuth::Strategy).
The result is that both the provided url parameter and the Referer header (if provided) are ignored.
The text was updated successfully, but these errors were encountered:
I have a pull request ready to go (#67), but all that said, I'm not sure how important this is except as a way of minimizing migration effort, since OmniAuth separately provides more or less the same functionality via the origin param.
Steps to reproduce:
/auth/:provider
as discussed in the Resolving CVE-2015-9284 wiki page./auth/calnet
, providing aurl
parameter in the request body:Expected:
Location
header in response includes the provided URLhttps://right.example.test/
Actual:
Location
header in response does not include anyurl
parameterNotes:
The issue is the assumption commented on line 211 here:
omniauth-cas/lib/omniauth/strategies/cas.rb
Lines 210 to 217 in 4ab8a1c
This only works for GET requests; for POST requests the parameter exists, but was never in in
request.query_string
to be copied by OmniAuth into the callback URL (see#callback_url
and#query_string
inOmniAuth::Strategy
).The result is that both the provided
url
parameter and theReferer
header (if provided) are ignored.The text was updated successfully, but these errors were encountered: