Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include correction/normalization factors in response surface files #51

Open
1 task done
stefan-voelk opened this issue Dec 1, 2024 · 0 comments
Open
1 task done
Assignees
Labels
module: core Related to the core module type: chore Converting measurements, reorganising folder strcuture, generally less impactful and painful tasks type: fix Iterations on existing features or infrastructure

Comments

@stefan-voelk
Copy link
Collaborator

Type of issue

  • feature request

Description

Please provide a description of the feature you are requesting. Please at least answer the following in your description:

  • What is the motivation/use case for this new feature?
    Instead of defining correction/normalization factor within the program, outsource to response surfaces files. The normalization factors are directly linked to the response surfaces itself. Therefore, these factors should be included in the response surfaces files.
  • Is the feature request related to a problem? If so, please describe.
    A possible problem with the current implementation occurs if the response surface is changed in the configuration file, but the correction/normalization is not adapted in the module calc_rsponse.py, e.g. CORR_RF_O3. Then, the computed output could be wrong.
  • Would you be able to help out? ♥️ Would you have the time and skills to implement the solution yourself?
    Yes! Yes!
@stefan-voelk stefan-voelk added type: chore Converting measurements, reorganising folder strcuture, generally less impactful and painful tasks type: fix Iterations on existing features or infrastructure module: core Related to the core module labels Dec 1, 2024
@stefan-voelk stefan-voelk self-assigned this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core Related to the core module type: chore Converting measurements, reorganising folder strcuture, generally less impactful and painful tasks type: fix Iterations on existing features or infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant