Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to (re)release on CRAN? #14

Open
richelbilderbeek opened this issue Dec 27, 2024 · 3 comments
Open

Plans to (re)release on CRAN? #14

richelbilderbeek opened this issue Dec 27, 2024 · 3 comments

Comments

@richelbilderbeek
Copy link

Dear maintainer(s) of the musicbrainz package,

Thanks for writing this package! I am a package maintainer too and want to get my package on CRAN. However, a rule to be on CRAN, is to only depend on packages that are on CRAN.

I think his package is intended to be on CRAN, as tn README.Rmd and README.md I find this CRAN status badge:

[![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/musicbrainz)](http://cran.r-project.org/package=musicbrainz)

However, I cannot find the package on CRAN at all.

What are the plans to (re)release the package on CRAN?

If needed, I can volunteer to get it on CRAN, as I have packaged multiple packages already.

Thanks and cheers, Richel Bilderbeek

@dmi3kno
Copy link
Owner

dmi3kno commented Dec 30, 2024

I dont know it feels like a big task to have a package on CRAN which depends on dplyr. I enjoyed having this as a hobby project.

Did you look under the hood? I wrote this when rlang was just getting started. I tried very hard to minimize metaprogramming. I updated quo_name() to curly-curly yesterday and bumped dependence on rlang to 0.4.0 where curly-curly was introduced.

Did you look at my ugly parsing code? Do you think you would write it like that? It's really messy API, so my code reflects that. The idea is to prepare the lists with arguments and then splice them where necessary. Splicing operator is therefore central to this package.

Do you think you would be able to take over the project? I am happy to step down if you feel like taking it further. I appreciate if you keep me in coauthors and stuff, but I dont feel like fighting the dependency nightmare with dplyr/purrr API. My map_dfr is probably going to be superceded soon, so I sense it will be a lot of work keeping it on CRAN. let me know what you think

@dmi3kno
Copy link
Owner

dmi3kno commented Dec 30, 2024

Proper testing needs to be implemented. I am inclined to go with httptest. Also there's some work to be done with unparsed/unproperly parsed includes. I will be busy in January-February. We could come back to this later in spring and try to catch up on all issues before you take over and run it to CRAN. At least I feel like I would want that, if I were in your shoes, I think.

@richelbilderbeek
Copy link
Author

richelbilderbeek commented Dec 30, 2024

I will think about taking over. But I am reluctant as -we agree- tests are missing and it is not on CRAN yet. However, we both enjoy the functionality of this package :-)

I would prefer to become a contributor and CRAN maintainer: I can make a Pull Request with things needed to get it on CRAN (you will remain the author of the package, as well as a contributor, as per usual) and then get it on CRAN and maintain it (at that time, I want to be a GitHub collaborator on this project). I prefer to have you around to do the harder coding :-)

I think your code is good enough. We agree that tests are missing.

Thanks for this fun reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants