Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a conda-forge DGL package #3498

Closed
knc6 opened this issue Nov 13, 2021 · 6 comments
Closed

Making a conda-forge DGL package #3498

knc6 opened this issue Nov 13, 2021 · 6 comments
Labels
feature request Feature request

Comments

@knc6
Copy link

knc6 commented Nov 13, 2021

🚀 Feature

Hi,

I would like to make a conda-forge package for ALIGNN network which uses DGL. As DGL is only available on its own conda channel and not on conda-forge, I submitted a PR for making a conda-forge DGL implementation here.

I would like to make sure if DGL team is ok with this strategy, or please suggest an alternative.

Currently, I am getting an error No such file or directory

Could someone from DGL team please take a look? My conda-recipe is here

Thanks.

@BarclayII
Copy link
Collaborator

Hi,

Thank you for your contribution! I'm not quite familiar with conda-forge so I was wondering what will be the difference between using a conda-forge repo and a third-party (i.e. dglteam's) repo?

@github-actions
Copy link

This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you

@hadim
Copy link

hadim commented Jan 29, 2022

I already made an attempt making a conda forge package for dgl. You can find more details at #1855 and conda-forge/staged-recipes#12552

@hadim
Copy link

hadim commented Jan 29, 2022

Thank you for your contribution! I'm not quite familiar with conda-forge so I was wondering what will be the difference between using a conda-forge repo and a third-party (i.e. dglteam's) repo?

In prod, it's a good practice to reduce the number of conda channels to depend on to reduce dep graph solving complexity. Also depending on multiple channels increase the surface of potential bugs in the packages since not all conda channels are maintained the same.

Conda forge is a community effort that guarantee package building will follow certain guidelines and good practices, so builds are reproducible.

Also currently, dgl provides different package names for different CUDA version (or CPU) which makes the maintenance of conda env file quite challenging (ideally a single env file should be valid and the same for multiple machine: CPU-only, CUDA-10, CUDA-11, etc). Conda has features to be able to automatically select a particular build (cpu, cuda, etc) according to the context.

@mikemhenry
Copy link

1.1.2 is now on conda-forge, so this issue can be closed.

@github-project-automation github-project-automation bot moved this from 🏠 Backlog to ✅ Done in DGL Project Tracker Oct 12, 2023
@Rhett-Ying
Copy link
Collaborator

1.1.3 is now on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Status: Done
Development

No branches or pull requests

6 participants