Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

CI reports linkcheck as passing for pull-requests even though it fails #751

Closed
leezu opened this issue Jun 7, 2019 · 2 comments
Closed
Labels
bug Something isn't working release focus Progress focus for release

Comments

@leezu
Copy link
Contributor

leezu commented Jun 7, 2019

@szha There is some bug in the CI setup for pull-requests. Even though the
linkcheck consistently failed for all pull-requests after #566, the CI did not
recognize the failure and reported the test as passing. Only on the master
branch, the CI correctly reports the test as failing.

See for example the log for #732:

@leezu leezu added the bug Something isn't working label Jun 7, 2019
@leezu leezu added the release focus Progress focus for release label Jun 7, 2019
@leezu
Copy link
Contributor Author

leezu commented Jun 7, 2019

This may be fixed by removing

This is tentatively done in #752.

@szha What was the reason to add

@szha
Copy link
Member

szha commented Jun 7, 2019

Some external websites were down so this was added as a temporary measure. it shouldn't be needed anymore.

@leezu leezu closed this as completed Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release focus Progress focus for release
Projects
None yet
Development

No branches or pull requests

2 participants