Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMeridiemText() from moment utils now returns translated text #478

Merged
merged 5 commits into from
Sep 28, 2020
Merged

getMeridiemText() from moment utils now returns translated text #478

merged 5 commits into from
Sep 28, 2020

Conversation

ScripterSugar
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #478 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #478   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          784       786    +2     
  Branches        91        93    +2     
=========================================
+ Hits           784       786    +2     
Impacted Files Coverage Δ
packages/moment/src/moment-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3082a23...bd0493e. Read the comment docs.

@dmtrKovalenko
Copy link
Owner

Thank you so much! If you don't mind can you also add a couple of tests to localization.test.ts file?

Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@dmtrKovalenko
Copy link
Owner

Oops, CI failed 😖

@ScripterSugar
Copy link
Contributor Author

ScripterSugar commented Sep 28, 2020

Working for it RN, I'm not quite used to those tests. Sorry.

@dmtrKovalenko
Copy link
Owner

No worries. I can take a look on failures if you won't resolve the problem. But in a few hours :)

@ScripterSugar
Copy link
Contributor Author

ScripterSugar commented Sep 28, 2020

Now it looks good to me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants