-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getMeridiemText() from moment utils now returns translated text #478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 784 786 +2
Branches 91 93 +2
=========================================
+ Hits 784 786 +2
Continue to review full report at Codecov.
|
Thank you so much! If you don't mind can you also add a couple of tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Oops, CI failed 😖 |
Working for it RN, I'm not quite used to those tests. Sorry. |
No worries. I can take a look on failures if you won't resolve the problem. But in a few hours :) |
Now it looks good to me. :) |
#473