-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of the date-io
adapters on MUI packages
#626
Comments
Hey, great questions.
|
Related to releases -- The repository is under my namespace and I added you as a collaborator. We can try to add a semantic release bot adnd release on each merge to release branch. But you need to make sure that CI is green |
Concerning the new methods, I started by adding them on our repo to stabilize them before adding them here. For the Luxon update.
Not sure to understand that one.
I'm not going to merge anything without a green CI of course. |
I mean that the end user of date-io is library and breaking change for library authors is not as hard as breaking change for end-users, but I would be much more happy if we can upgrade without any breaking changes if possible. We didn't have braking changes for couple years and we need to remove already not working functionality for inferring types through npm modules. So feel free to update luxon right now. |
I guess that would be a major of the How do you want to do it ? |
I have a pr #416 which is a breaking change in terms of the whole package |
Since MUI doesn't have a dependency on @date-io anymore (https://github.com/mui/mui-x/releases/tag/v6.3.0), maybe this issue should be closed? |
I am starting this discussion, because we are starting a major rework of our date and time pickers, which will require to modify the adapters significantly.
Therefore, we would like to discuss with you beforehand to see how you feel about
@date-io
and how we can organize together to improve this project with as little friction as possible.Here are a few examples of evolution we will need:
startOfHour
/endOfHour
/ ...DateTime.expandFormat
utility method.This raises two major questions:
@date-io
startOfHour
and to avoid friction if your are on vacation for instanceBest regards,
Flavien
The text was updated successfully, but these errors were encountered: