Fix SYSINFO_RET_FAIL and quotes ?! #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently as in dnaeon#254 described if vcenter or host is not available the returned zabbix result is still OK instead of FAIL. It should be FAIL as then we can define an nodata() trigger on an host status or directly vcenter status and make other triggers dependent. A little bit like with Zabbix Agent Status. I'm not into C so if might done it false? It compiled and seamed to work for me.
This should fix dnaeon#246 as zabbix already recognizes the string.
rockaut
changed the title
dnaeon
reviewed
Sep 3, 2018
missing \
missing GOVC_VERSION
Docker latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently as in #254 described if vcenter or host is not available the returned zabbix result is still OK instead of FAIL. This should fix #254
It should be FAIL as then we can define an nodata() trigger on an host status or directly vcenter status and make other triggers dependent. A little bit like with Zabbix Agent Status.
I'm not into C so i might done it wrong? It compiled and seamed to work for me but may please verify anyone?