Fix UDP source ip #178
Open
Fix UDP source ip #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
force-pushed
the
fix-udp-source-ip
branch
from
dafce86 to
217de07
Compare
This fixes an issue when phantun may choose a source IP different from the destination IP in the incoming packet. Closes dndx#177
WGH-
force-pushed
the
fix-udp-source-ip
branch
from
217de07 to
5b82789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the destination IP address from incoming UDP packets, and use bind the local sockets to it to ensure we always reply from the same source as remote UDP peer used as destination to contact us. See #177 for concrete example of the problem.
I've tested this in following scenarios:
[::]:51820, but the UDP peer "connects" over IPv4)Closes #177