From 379623e637b8a3fa9dfc2e2708acbaf2124fc7b3 Mon Sep 17 00:00:00 2001 From: Vincent Demeester Date: Tue, 27 Jun 2017 13:44:59 +0200 Subject: [PATCH] Rename NewConfigFile to New in configfile package Signed-off-by: Vincent Demeester --- cli/command/image/pull_test.go | 4 ++-- cli/command/image/push_test.go | 4 ++-- cli/config/config.go | 2 +- cli/config/config_test.go | 2 +- cli/config/configfile/file.go | 4 ++-- cli/config/configfile/file_test.go | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/cli/command/image/pull_test.go b/cli/command/image/pull_test.go index 731c774a1cf2..690e6222ebb1 100644 --- a/cli/command/image/pull_test.go +++ b/cli/command/image/pull_test.go @@ -43,7 +43,7 @@ func TestNewPullCommandErrors(t *testing.T) { for _, tc := range testCases { buf := new(bytes.Buffer) cli := test.NewFakeCli(&fakeClient{}, buf) - cli.SetConfigfile(configfile.NewConfigFile("filename")) + cli.SetConfigfile(configfile.New("filename")) cmd := NewPullCommand(cli) cmd.SetOutput(ioutil.Discard) cmd.SetArgs(tc.args) @@ -68,7 +68,7 @@ func TestNewPullCommandSuccess(t *testing.T) { for _, tc := range testCases { buf := new(bytes.Buffer) cli := test.NewFakeCli(&fakeClient{}, buf) - cli.SetConfigfile(configfile.NewConfigFile("filename")) + cli.SetConfigfile(configfile.New("filename")) cmd := NewPullCommand(cli) cmd.SetOutput(ioutil.Discard) cmd.SetArgs(tc.args) diff --git a/cli/command/image/push_test.go b/cli/command/image/push_test.go index f02e0407d649..f2c35dee21dc 100644 --- a/cli/command/image/push_test.go +++ b/cli/command/image/push_test.go @@ -49,7 +49,7 @@ func TestNewPushCommandErrors(t *testing.T) { for _, tc := range testCases { buf := new(bytes.Buffer) cli := test.NewFakeCli(&fakeClient{imagePushFunc: tc.imagePushFunc}, buf) - cli.SetConfigfile(configfile.NewConfigFile("filename")) + cli.SetConfigfile(configfile.New("filename")) cmd := NewPushCommand(cli) cmd.SetOutput(ioutil.Discard) cmd.SetArgs(tc.args) @@ -74,7 +74,7 @@ func TestNewPushCommandSuccess(t *testing.T) { return ioutil.NopCloser(strings.NewReader("")), nil }, }, buf) - cli.SetConfigfile(configfile.NewConfigFile("filename")) + cli.SetConfigfile(configfile.New("filename")) cmd := NewPushCommand(cli) cmd.SetOutput(ioutil.Discard) cmd.SetArgs(tc.args) diff --git a/cli/config/config.go b/cli/config/config.go index 5e638a519f37..90529ebd4c0b 100644 --- a/cli/config/config.go +++ b/cli/config/config.go @@ -69,7 +69,7 @@ func Load(configDir string) (*configfile.ConfigFile, error) { } filename := filepath.Join(configDir, ConfigFileName) - configFile := configfile.NewConfigFile(filename) + configFile := configfile.New(filename) // Try happy path first - latest config file if _, err := os.Stat(filename); err == nil { diff --git a/cli/config/config_test.go b/cli/config/config_test.go index 1248913c5ee4..c885d3e72478 100644 --- a/cli/config/config_test.go +++ b/cli/config/config_test.go @@ -540,7 +540,7 @@ func TestLoadDefaultConfigFile(t *testing.T) { configFile := LoadDefaultConfigFile(buffer) credStore := credentials.DetectDefaultStore("") - expected := configfile.NewConfigFile(filename) + expected := configfile.New(filename) expected.CredentialsStore = credStore expected.PsFormat = "format" diff --git a/cli/config/configfile/file.go b/cli/config/configfile/file.go index d599cc5aa99b..babd63693b21 100644 --- a/cli/config/configfile/file.go +++ b/cli/config/configfile/file.go @@ -54,8 +54,8 @@ type ProxyConfig struct { FTPProxy string `json:"ftpProxy,omitempty"` } -// NewConfigFile initializes an empty configuration file for the given filename 'fn' -func NewConfigFile(fn string) *ConfigFile { +// New initializes an empty configuration file for the given filename 'fn' +func New(fn string) *ConfigFile { return &ConfigFile{ AuthConfigs: make(map[string]types.AuthConfig), HTTPHeaders: make(map[string]string), diff --git a/cli/config/configfile/file_test.go b/cli/config/configfile/file_test.go index 4e24009777da..f2a61b179479 100644 --- a/cli/config/configfile/file_test.go +++ b/cli/config/configfile/file_test.go @@ -137,13 +137,13 @@ func TestProxyConfigPerHost(t *testing.T) { func TestConfigFile(t *testing.T) { configFilename := "configFilename" - configFile := NewConfigFile(configFilename) + configFile := New(configFilename) assert.Equal(t, configFilename, configFile.Filename) } func TestGetAllCredentials(t *testing.T) { - configFile := NewConfigFile("filename") + configFile := New("filename") exampleAuth := types.AuthConfig{ Username: "user", Password: "pass",