Change download logic to not completely abort in certain delegation failure cases #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have enough signatures or is expired Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
skip-invalid-delegations
branch
from
cd2fb39 to
4b75d58
Compare
| @@ -1087,6 +1099,14 @@ func TestUpdateNonRootRemoteCorruptedCannotUseLocalCache(t *testing.T) { | |||
| if testing.Short() { | |||
| t.Skip("skipping test in short mode") | |||
| } | |||
|
|
|||
| acceptDelgAnyway := map[string]struct{}{ | |||
There was a problem hiding this comment.
I think it might be worth factoring this out into a global var like waysToMessUpServer
cyli
force-pushed
the
skip-invalid-delegations
branch
from
a01e44c to
df46182
Compare
|
LGTM |
| @@ -1078,6 +1104,22 @@ func TestUpdateNonRootRemoteCorruptedCanUseLocalCache(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // requires that a delegation role and its decendents were not accepted as a valid part of the | |||
|
LGTM pending CI - documentation CI errors are unrelated |
…heck that bad delegations aren't accepted Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
skip-invalid-delegations
branch
from
df46182 to
b3982e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance if there aren't enough signatures, or if the metadata is expired