Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOM-255: Add support for using TABS (for indentation) in DocBlock Annotations #564

Closed
doctrinebot opened this issue Oct 12, 2014 · 2 comments
Assignees
Labels

Comments

@doctrinebot
Copy link

Jira issue originally created by user henrywood:

Apparently any annotation that contains at least one TAB character is ignored.

The reason/bug resides in \Doctrine\Common\Annotations\DocParser->findInitialTokenPosition() on line 351

// if the @ is preceded by a space or * it is valid

Thanks

@doctrinebot
Copy link
Author

Comment created by @Ocramius:

[~henrywood] this seems to be easily fixable by using something like preg_match('/^(\\t](\\*)$/', $input[$pos - 1)): can you provide a PR?

I'm just not sure about the performance impact here.

Note that JIRA screws with my regex in the quoted text, as escape sequences don't match what I entered.

@guilhermeblanco
Copy link
Member

This issue was moved to doctrine/annotations#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants