Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sharding exception codes into constants #3132

Closed
Majkl578 opened this issue May 5, 2018 · 2 comments
Closed

Extract sharding exception codes into constants #3132

Majkl578 opened this issue May 5, 2018 · 2 comments
Labels
Improvement

Comments

@Majkl578
Copy link
Contributor

Majkl578 commented May 5, 2018

It looks pretty random now, constants would help understanding these codes.

https://github.com/doctrine/dbal/blob/v2.7.1/lib/Doctrine/DBAL/Sharding/ShardingException.php#L36
@morozov
Copy link
Member

morozov commented Oct 30, 2021

Irrelevant as of #3602.

@morozov morozov closed this as completed Oct 30, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morozov @Majkl578