Mapping discrepancy for ManyToOne with new inference

[TristanPouliquen]

Hello,

I've come across a discrepancy in the SQL produced by Doctrine for ManyToOne annotations. As stated in the official documentation, the JoinColumn should infer the nullable from the attribute type definition.

However, this is actually not the case.

I've created a minimal reproduction case in this repository.

As you can see in EntityC, I've defined one ManyToOne with PHP7.4 typed attributes and the other without it.

In the dump of my SQL schema, you can see that the SQL statements for both fields are not the same, when they should normally be.

The statement for the relationship with EntityA, defined with a typed attribute, has a DEFAULT NULL clause that should not happen.

How can I help going ahead in fixing this?

[TristanPouliquen]

There also seems to have an error in the inference of the nullable attribute for simple types. I have updated my reproduction to insert a typed nullable string attribute, that generates a VARCHAR NOT NULL in my Doctrine schema.

[greg0ire]

How can I help going ahead in fixing this?

Finding who introduced the new inference and it which PR would help finding the best people to help with this `git log -S 'some string' should help with this.

[mbabker]

Nullable inference was backed out in #8732 due to B/C issues.

[TristanPouliquen]

Ah, thanks to both of you. I had tried to look for similar issues but did not come across these ones.

Too bad it has been reversed, but I understand the BC point of view. I'll wait for the 3.x to remove these last bits of redundant annotations!

Cheers!