Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 4 support broken due to mime@2 update. #1014

Closed
rwjblue opened this issue Feb 12, 2018 · 2 comments
Closed

Node 4 support broken due to mime@2 update. #1014

rwjblue opened this issue Feb 12, 2018 · 2 comments

Comments

@rwjblue
Copy link

rwjblue commented Feb 12, 2018 •
edited
Loading

mime@2 was upgrade to in #1003 and subsequently released in 5.4.0.

Since documentation indicates that it supports node >= 4 and [email protected] requires node >= 6 this was a breaking change.
@tmcw
Copy link
Member

tmcw commented Feb 12, 2018

Thanks for noting this. We should probably update documentation.js to be node >= 6, given that node v4 is end-of-life on March 30, less than 2 months away.

@rwjblue
Copy link
Author

rwjblue commented Feb 12, 2018

Ya, seems great to bump majors and release with Node >= 6 as a requirement. In the meantime, any objections to reverting #1003 and releasing 5.4.1?

@rwjblue rwjblue mentioned this issue Feb 12, 2018
Merged
@tmcw tmcw mentioned this issue Mar 2, 2018
Merged
@tmcw tmcw closed this as completed in #1033 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @tmcw