-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make experimental speed changes standard and add esbuild plugin #428
Conversation
9d6190d
to
a6fd2e4
Compare
@@ -123,7 +114,7 @@ window['${libraryName}'].base = '${base}'</script>`, | |||
config.plugins.push( | |||
new BuildTimeRender({ | |||
...args['build-time-render'], | |||
sync: singleBundle, | |||
sync: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does BTR always need to be "sync" with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not positive whether BTR breaks if it's async for a single bundle. Since the dev build here is now always a single bundle I just converted all the single bundle conditionals to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTR is still async unless singleBundle
is explicitly set to true for the dist build, if that wasn't clear.
Closing this PR, there is basic support for esbuild now and there are signifiant conflicts. However some of these changes will need to be considered when re-visiting the performance issue #217 |
Type: feature
The following has been addressed in the PR:
prettier
Description:
This moves the "experimental" speed features into the standard development build where possible, also adding esbuild to replace the ts-loader.
cli-create-app
dev build times went from 9-10 seconds to 7-8 seconds.Resolves #217