From a3727acd4e4d7288f95b702184c332f52acbd3f1 Mon Sep 17 00:00:00 2001 From: Ammar Arif Date: Tue, 10 Sep 2024 18:58:02 -0400 Subject: [PATCH] fix(katana-tasks): ensure is cancelled before waiting on shutdown (#2412) --- crates/katana/tasks/src/manager.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/katana/tasks/src/manager.rs b/crates/katana/tasks/src/manager.rs index e7095786c5..42681079d1 100644 --- a/crates/katana/tasks/src/manager.rs +++ b/crates/katana/tasks/src/manager.rs @@ -52,7 +52,12 @@ impl TaskManager { /// /// No task can be spawned on the manager after this method is called. pub async fn shutdown(self) { + if !self.on_cancel.is_cancelled() { + self.on_cancel.cancel(); + } + self.wait_for_shutdown().await; + // need to close the tracker first before waiting let _ = self.tracker.close(); self.tracker.wait().await;