Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): use same versioned constant as snos #2956

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat(blockifier): use same versioned constant as snos #2956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3872241
feat: pin versioned constant to v0.13.3
kariy Jan 27, 2025
6f51dc0
Merge branch 'main' into katana/versioned-constant
kariy Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/katana/executor/src/implementation/blockifier/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ use katana_cairo::cairo_vm::types::errors::program_errors::ProgramError;
use katana_cairo::cairo_vm::vm::runners::cairo_runner::{ExecutionResources, RunResources};
use katana_cairo::starknet_api::block::{
BlockInfo, BlockNumber, BlockTimestamp, FeeType, GasPriceVector, GasPrices, NonzeroGasPrice,
StarknetVersion,
};
use katana_cairo::starknet_api::contract_class::{ClassInfo, EntryPointType, SierraVersion};
use katana_cairo::starknet_api::core::{
Expand Down Expand Up @@ -442,7 +443,18 @@ pub fn block_context_from_envs(block_env: &BlockEnv, cfg_env: &CfgEnv) -> BlockC

let chain_info = ChainInfo { fee_token_addresses, chain_id: to_blk_chain_id(cfg_env.chain_id) };

let mut versioned_constants = VersionedConstants::latest_constants().clone();
// IMPORTANT:
//
// The versioned constants that we use here must match the version that is used in `snos`.
// Otherwise, there might be a mismatch between the calculated fees.
//
// The version of `snos` we're using is still limited up to Starknet version `0.13.3`.
const SN_VERSION: StarknetVersion = StarknetVersion::V0_13_3;
let mut versioned_constants = VersionedConstants::get(&SN_VERSION).unwrap().clone();

// NOTE:
// These overrides would potentially make the `snos` run be invalid as it doesn't know about the
// new overridden values.
versioned_constants.max_recursion_depth = cfg_env.max_recursion_depth;
versioned_constants.validate_max_n_steps = cfg_env.validate_max_n_steps;
versioned_constants.invoke_tx_max_n_steps = cfg_env.invoke_tx_max_n_steps;
Expand Down
Loading