feat(katana): make trie rpc types cloneable

[kariy]

Summary by CodeRabbit

• Refactor
  • Improved underlying data management processes to enhance the duplication capabilities of core components. These optimizations streamline internal operations and lay the groundwork for future enhancements, ensuring reliable performance and consistency. While these updates are internal and do not change visible functionality, they support ongoing efforts to maintain a robust and efficient system.

[coderabbitai]

Ohayo sensei! Here’s the overview of the recent changes:

Walkthrough

The diff updates the derive macros for several structs in the trie.rs file by adding the Clone trait alongside the existing traits. This change affects structs like GlobalRoots, GetStorageProofResponse, ClassesProof, ContractsProof, ContractLeafData, ContractStorageProofs, NodeWithHash, and Nodes. There are no alterations to struct fields or methods; the update is limited to enhancing trait support for cloning instances.

Changes

File	Change Summary
crates/katana/.../rpc-types/src/trie.rs	Added Clone to derive macros on structs: GlobalRoots, GetStorageProofResponse, ClassesProof, ContractsProof, ContractLeafData, ContractStorageProofs, NodeWithHash, Nodes

Possibly related PRs

• fix(katana-rpc-types): proofs types serde #2872: Adjustments to serialization attributes in similar trie structs, with overlaps on ClassesProof, ContractStorageProofs, and Nodes.

Suggested reviewers

• glihm

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76b2858 and 28e22ad.

📒 Files selected for processing (1)

• crates/katana/rpc/rpc-types/src/trie.rs (4 hunks)

🔇 Additional comments (8)

crates/katana/rpc/rpc-types/src/trie.rs (8)

18-25: Ohayo! Clone derivation looks good for GlobalRoots.

The addition of the Clone trait to GlobalRoots makes sense since it allows creating duplicates of this struct when needed.

---

67-77: The Clone trait is a sensible addition to GetStorageProofResponse, sensei!

Adding cloneability to this response struct will enhance usability when manipulating proof data.

---

79-83: Nice addition of Clone to ClassesProof!

This transparent struct will now be properly cloneable, which aligns well with its usage.

---

85-92: Ohayo! The Clone trait makes ContractsProof more versatile.

Adding cloneability to this struct is beneficial for cases where contract proofs need to be duplicated.

---

94-102: Well done adding Clone to ContractLeafData, sensei!

This struct contains important contract state data, and making it cloneable will help when working with this data.

---

104-108: The Clone derivation for ContractStorageProofs is perfect!

This transparent wrapper for proof nodes can now be properly cloned.

---

110-114: Ohayo! NodeWithHash is now cloneable - excellent addition.

Making this struct cloneable ensures individual node data can be duplicated when needed.

---

116-118: The Clone trait addition to Nodes completes the set nicely, sensei!

This transparent wrapper struct now supports cloning, which is consistent with the other changes.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (9b93308) to head (28e22ad).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
- Coverage   57.49%   57.39%   -0.11%     
==========================================
  Files         439      440       +1     
  Lines       59820    59948     +128     
==========================================
+ Hits        34392    34405      +13     
- Misses      25428    25543     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.