fix(torii-graphql): option enums in arrays

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved data mapping to ensure every expected field appears in query responses. Now, if a field is missing, a default value (null or a specific fallback for certain fields) is provided, yielding more consistent and predictable data outputs.

[coderabbitai]

Ohayo sensei, please find the pull request details below:

Walkthrough

The update refines the populate_value logic within the GraphQL query processing. The revised implementation checks for the existence of each field before processing. If a field exists, it uses its corresponding type to call populate_value. If it is missing, a new entry is added—assigning either a Value::Null or, if the field name is "option", a Value::String with the first key's string representation. This change explicitly handles missing fields while preserving expected behavior.

Changes

File	Change Summary
crates/torii/graphql/src/query/mod.rs	Modified populate_value in value_mapping_from_row to check for field existence; inserts default values (Null or specific string for "option") for missing fields

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant VM as value_mapping_from_row
    participant PV as populate_value
    participant Checker as Field Checker

    Caller->>VM: Call with row data
    VM->>Checker: Check if field exists
    alt Field exists
        Checker-->>VM: Return field type
        VM->>PV: Process field with type
    else Field missing
        Checker-->>VM: No field found
        alt Field name is "option"
            VM->>VM: Insert Value::String(first key)
        else
            VM->>VM: Insert Value::Null
        end
    end
    VM-->>Caller: Return updated mapping

Loading

Suggested reviewers

• glihm

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3093f3a and bef8151.

📒 Files selected for processing (1)

• crates/torii/graphql/src/query/mod.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/torii/graphql/src/query/mod.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.38%. Comparing base (76b2858) to head (39612ca).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/graphql/src/query/mod.rs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
- Coverage   57.40%   57.38%   -0.02%     
==========================================
  Files         440      440              
  Lines       59948    59948              
==========================================
- Hits        34413    34402      -11     
- Misses      25535    25546      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.