-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doublecheck and tweak the flow of the turorial #4
Comments
Things that come to mind:
@dominikwelke, could you add what thing you think might use some updating? Then we could discuss them all together. |
|
i'll open a branch + pr |
another option would be, to first show the average psd/snr of ALL trials, which means there would be 12hz and 15hz peaks (presumably less prominent) possible benefits might be:
|
Yeah! We could also offer this as an alternative to a predefined roi. As long as it is not based on the comparison between the conditions, we should be good.
Not sure I'd be able to interpret that. |
Good point.
Yeah, makes sense as the justification for preferring snrs.
Not sure what you mean by "quantification of the peaks".
Yeah, we can plot the data itself in addition to doing a test. |
I suggest we link the PR to this issue (adding "closes #4" in the first comment of the PR) and add a checkbox list in the first cell of this issue. It will help us to keep track of what we decide to do. Would that be alright? |
Yeah, I got confused with github's cross-referencing of issues/prs. Of course, the checklist should go into PR. Let's add/remove points there as we discuss this. I've already added the points that I think we agree on. |
The text was updated successfully, but these errors were encountered: