From be1eb4cca8f5a9c4b33e4da052f2d28445b4a489 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Thu, 14 Jan 2021 18:00:23 +0000 Subject: [PATCH] chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation (#88346) --- .npmrc | 1 + package.json | 3 --- src/dev/build/tasks/clean_tasks.ts | 5 ++++- src/dev/build/tasks/copy_source_task.ts | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 .npmrc diff --git a/.npmrc b/.npmrc new file mode 100644 index 0000000000000..5c6ff9df9dd25 --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +puppeteer_skip_chromium_download=true diff --git a/package.json b/package.json index 8d4fec8e93c21..df8a41f29bf79 100644 --- a/package.json +++ b/package.json @@ -19,9 +19,6 @@ "number": 8467, "sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9" }, - "config": { - "puppeteer_skip_chromium_download": true - }, "homepage": "https://www.elastic.co/products/kibana", "bugs": { "url": "http://github.com/elastic/kibana/issues" diff --git a/src/dev/build/tasks/clean_tasks.ts b/src/dev/build/tasks/clean_tasks.ts index eb6d68efd8a66..daae4e238df08 100644 --- a/src/dev/build/tasks/clean_tasks.ts +++ b/src/dev/build/tasks/clean_tasks.ts @@ -41,7 +41,10 @@ export const CleanPackages: Task = { description: 'Cleaning source for packages that are now installed in node_modules', async run(config, log, build) { - await deleteAll([build.resolvePath('packages'), build.resolvePath('yarn.lock')], log); + await deleteAll( + [build.resolvePath('packages'), build.resolvePath('yarn.lock'), build.resolvePath('.npmrc')], + log + ); }, }; diff --git a/src/dev/build/tasks/copy_source_task.ts b/src/dev/build/tasks/copy_source_task.ts index 038ccba5ed17e..2a66d3d394066 100644 --- a/src/dev/build/tasks/copy_source_task.ts +++ b/src/dev/build/tasks/copy_source_task.ts @@ -27,6 +27,7 @@ export const CopySource: Task = { dot: false, select: [ 'yarn.lock', + '.npmrc', 'src/**', '!src/**/*.{test,test.mocks,mock}.{js,ts,tsx}', '!src/**/mocks.ts', // special file who imports .mock files