Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected files are include in the npm release 1.0.16 #1

Closed
xdjinnx opened this issue Oct 9, 2017 · 4 comments
Closed

Unexpected files are include in the npm release 1.0.16 #1

xdjinnx opened this issue Oct 9, 2017 · 4 comments

Comments

@xdjinnx
Copy link

xdjinnx commented Oct 9, 2017

There are files that are not expected to be included in the npm release of xelement.

These files are: .suo, .npmignore and xelement.sln

You should commit these files to the repository.

OBS! I would not commit the .suo file because this is not an intended file to be commited, see here: https://msdn.microsoft.com/en-us/library/bb165909.aspx

Also I would not commit the .vs folder at all. Because the github gitignore template for VisualStudio suggest to ignore this folder. See: https://github.com/github/gitignore/blob/master/VisualStudio.gitignore

The .suo file is causing problems for everyone using electron-updater at the moment because it's seen as a binary. electron-updater is using xelement as a dependency. The smartUnpack in electron builder is unpacking all dependencies that has a binary or an executable present in the module.

@develar
Copy link

develar commented Oct 13, 2017

electron-builder 19.37.1 will exclude such files.

electron-updater 2.12.x will probably use another xml lib.

@develar
Copy link

develar commented Oct 14, 2017

@xdjinnx
Copy link
Author

xdjinnx commented Oct 14, 2017

Nice fix!

Even though it's fixed in electron-builder. It would be nice for users using an older version of electron-updater to release a new version of xelement fixing mentioned problem.

@dongariteja
Copy link
Owner

all unnecessary files has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants